[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Memory leak in svn_ra_get_file() with svn+ssh://?

From: Philipp Marek <philipp_at_marek.priv.at>
Date: 2007-10-06 09:26:43 CEST

Hello Dave!

On Saturday 06 October 2007 David Glasser wrote:
> On 10/5/07, David Glasser <glasser@davidglasser.net> wrote:
> > On 10/2/07, Philipp Marek <philipp@marek.priv.at> wrote:
> > > Hello everybody,
> > >
> > > I think there's a memory leak in svn_ra_get_file() or the svn+ssh RA
> > > layer. FSVS (http://fsvs.tigris.org) uses svn_ra_get_file() eg. for
> > > reverts - to fetch a clean copy of a file from the repository.
> >
> > Thanks for the bug report! It does in fact look to me like there is a
> > memory leak in libsvn_ra_svn/client.c(ra_svn_get_file). I'll commit
> > this as soon as tests finish passing (hopefully this will be before I
> > go home today).
>
> Committed in r26964, nominated for backport in r26965. Will be
> reverted when I find out my currently-running test suite fails :)

Could you *please* *please* *please* change the read size to something
higher - how about 128k instead of the 4k we currently have?

Similar for the ra_file layer ... there's 16k, but I think that is much too
low for current machines; we loose too much on context switches.

Regards,

Phil

-- 
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 6 09:27:08 2007

This is an archived mail posted to the Subversion Dev mailing list.