[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26954 - trunk/subversion/mod_dav_svn/reports

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-10-06 03:46:43 CEST

hwright@tigris.org writes:
> Log:
> Fix issue #2913: Add depth information to DAV operational log.
>
> * subversion/mod_dav_svn/reports/update.c
> (dav_svn__update_report): Add the requested depth to the operational log.

Yay!

The change looks right to me. I'm curious: when you test plain 'svn
up' and other operations (with no --depth flag passed) over DAV, what
do you see in the logs? Do you see "svn_depth_unknown", or do you see
"svn_depth_infinity"?

It should be the former, but for various reasons it might be the
latter, and if so I'd like to know about it.

(I could just test this myself, but I figure you've already got
everything set up to do so, and could do it much faster.)

-Karl

> Modified: trunk/subversion/mod_dav_svn/reports/update.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/mod_dav_svn/reports/update.c?pathrev=26954&r1=26953&r2=26954
> ==============================================================================
> --- trunk/subversion/mod_dav_svn/reports/update.c (original)
> +++ trunk/subversion/mod_dav_svn/reports/update.c Fri Oct 5 10:16:27 2007
> @@ -1343,23 +1343,26 @@
> reports it (and it alone) to the server as being empty. */
> if (entry_counter == 1 && entry_is_empty)
> action = apr_psprintf(resource->pool,
> - "checkout-or-export '%s' r%ld",
> + "checkout-or-export '%s' r%ld %s",
> svn_path_uri_encode(spath, resource->pool),
> - revnum);
> + revnum,
> + svn_depth_to_word(requested_depth));
> else
> {
> if (text_deltas)
> action = apr_psprintf(resource->pool,
> - "update '%s' r%ld",
> + "update '%s' r%ld %s",
> svn_path_uri_encode(spath,
> resource->pool),
> - revnum);
> + revnum,
> + svn_depth_to_word(requested_depth));
> else
> action = apr_psprintf(resource->pool,
> - "remote-status '%s' r%ld",
> + "remote-status '%s' r%ld %s",
> svn_path_uri_encode(spath,
> resource->pool),
> - revnum);
> + revnum,
> + svn_depth_to_word(requested_depth));
> }
> }
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 6 03:46:56 2007

This is an archived mail posted to the Subversion Dev mailing list.