[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [FSFS] Do not pass txn_id when not used

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-10-06 01:12:20 CEST

On 10/5/07, Blair Zajac <blair@orcaware.com> wrote:
> Daniel L. Rall wrote:
> > On Fri, 05 Oct 2007, Bhuvaneswaran Arumugam wrote:
> >
> >> Hello,
> >>
> >> This fix is similar to r26940. In few of FSFS functions, do not pass
> >> txn_id parameter when it is not used.
> >>
> >> [[
> >> In FSFS libraries, for few functions, do not pass txn_id parameter when
> >> it is not used.
> >>
> >> * subversion/libsvn_fs_fs/dag.h
> >> (svn_fs_fs__dag_finalize_edits): Remove txn_id argument.
> >> Update the comment to reflect this change.
> >> * subversion/libsvn_fs_fs/dag.c
> >> (svn_fs_fs__dag_finalize_edits): Remove txn_id argument.
> >> * subversion/libsvn_fs_fs/tree.c
> >> (update_ancestry): Remove txn_id argument.
> >> (merge, text_stream_closer): Adjust the callers.
> >>
> >> Patch by: bhuvan
> >> ]]
> >
> > Looks good, Bhuvan. +1 to commit.
>
> How come I don't see warnings from gcc on these unused parameters? I guess it
> doesn't it warn when a parameter is not used?

I guess an unused parameter warning could have lots of false positives
from when functions are required to have specific parameter lists for
backwards compatibility reason or to be passed as a function
pointer...

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 6 01:12:29 2007

This is an archived mail posted to the Subversion Dev mailing list.