[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Merging the svndiff-patch branch to trunk

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-10-05 21:52:02 CEST

On 10/4/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
> Just wondering where we're at in the process of merging the
> svndiff-patch branch to trunk. It'd be good to get it there so others
> can start playing with it, and to get it into the 1.5 release. I'd hate
> to have to wait until 1.6 to release code from SoC '07.
> I know that Charles has been working on the branch a bit lately.
> Charles, what would it take to get it mergeable, and do you think you
> can have that ready in the next day or two?
> It'd also be good if some of the committers reviewed what's there. I
> haven't had the chance to yet, but hope to take a look sometime this
> weekend.

I am personally -1 on merging this branch to trunk until it gets quite
a bit more review. As far as I can, a large amount of Charles'
commits were not reviewed by any committers. I have started doing
some review recently, but (a) that was only after a large amount of
the work was done and (b) my comments were often somewhat superficial.

My general impression of the branch is that it is an important feature
that we should try to get released by 1.6 at the latest, but that
there are actually a huge number of complications that I don't think
were recognized until Charles actually tried to do it. Charles is
doing a great job*, but the feature is complex enough that more review
of his commits (not just the newer ones, but the earlier ones that
didn't get any review) is essential in order for us to be confident
that the implementation lives up to the project's standards.

I will try to keep reviewing his new commits, but I'm not sure if I
have time to go back and look at the older ones. Can anyone volunteer
to do so?

(I am also generally concerned that 1.5 will end up being a release of
a large number of half-baked features. It's also worth pointing out
that the big features currently being implemented (merge tracking,
sparse directories, extra copyfrom information, svnpatch, etc etc etc)
do interact with each other in subtle and complicated ways. Pushing
at least one of them off until 1.6 will limit the combinatorial
explosion of interactions between new features in 1.5.)


* and please don't read anything in this vote to suggest otherwise!
I'm really happy with Charles's work so far... but the feature is
complex enough that one newcomer to the project shouldn't be expected
to be able to complete it solo without much review!

David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 5 21:52:13 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.