[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Minor UI Consistency Nit

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-10-04 01:28:18 CEST

On Wed, 03 Oct 2007, Augie Fackler wrote:

> In my fairly extensive abuse of the svn binary while testing the
> conflict resolution patch of mine that was just accepted, I noticed
> that the missing log message prompt doesn't have balanced
> parentheses, and that makes me sad. I noticed this because that menu
> felt less aesthetically pleasing than the conflict resolution UI,
> which does have balanced parens.

Better yet, it feeds our collective neurosis.

> The attached patch (includes log message in the patch file) fixes
> that so that the parentheses are balanced, just like in the conflict
> resolution UI sussman wrote. As far as I can tell, this is the only
> other menu-based interactive prompt, so it's the only other place
> that needs to be fixed.

There are some other interactive prompts -- example:

(R)eject, accept (t)emporarily or accept (p)ermanently?

In any case, +1 -- committed in r26919. Thanks Augie!

- Dan

  • application/pgp-signature attachment: stored
Received on Thu Oct 4 01:28:30 2007

This is an archived mail posted to the Subversion Dev mailing list.