[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 2950] New - Weird prompting to resolve conflicts when EDITOR is not defined

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2007-10-02 03:32:47 CEST

"Ben Collins-Sussman" <sussman@red-bean.com> writes:

> Guys, I have a patch to fix this problem (attached) which just adds
> svn_cmdline_fflush() after every call to svn_cmdline_printf() within
> in the interactive conflict loop.
>
> It seems sort of hacky to me though. epg was thinking that maybe we
> should change svn_cmdline_printf() to automatically fflush() if the
> incoming string ends with \n. What do people think?

I thought that until I found out they're just using stdio, not
APR foo. In that case, I advocate setting line buffering in
svn_cmdline_init, something like:

  setvbuf(stderr, NULL, _IOLBF, 0);
  setvbuf(stdout, NULL, _IOLBF, 0);

This prompt stuff isn't the only stuff to have the problem, and
the problem isn't new. Any poor schmuck who does

  svn foo > log 2>&1 &
  tail -f log

is annoyed that status comes through in 8K chunks. I am
frequently that schmuck ;->. So, doing it in either
svn_cmdline_fputs or svn_cmdline_init (better) will save a bunch
of flushing all over the place.

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 2 03:32:57 2007

This is an archived mail posted to the Subversion Dev mailing list.