On Fri, 28 Sep 2007, David Glasser wrote:
...
> Index: subversion/include/svn_config.h
> ===================================================================
> --- subversion/include/svn_config.h (revision 26831)
> +++ subversion/include/svn_config.h (working copy)
> @@ -121,9 +121,17 @@ typedef struct svn_config_t svn_config_t
> /*** Configuration Default Values ***/
>
> /* '*' matches leading dots, e.g. '*.rej' matches '.foo.rej'. */
> +/* We want this to be printed on two lines in the generated config file,
> + * but we don't want the # character to end up in the variable.
> + */
> +#define SVN_CONFIG__DEFAULT_GLOBAL_IGNORES_LINE_1 \
> + "*.o *.lo *.la *.al .libs *.so *.so.[0-9]* *.a *.pyc *.pyo"
> +#define SVN_CONFIG__DEFAULT_GLOBAL_IGNORES_LINE_2 \
> + "*.rej *~ #*# .#* .*.swp .DS_Store"
> +
> #define SVN_CONFIG_DEFAULT_GLOBAL_IGNORES \
> - "*.o *.lo *.la *.al .libs *.so *.so.[0-9]* *.a *.pyc *.pyo" \
> - " *.rej *~ #*# .#* .*.swp .DS_Store"
> + SVN_CONFIG__DEFAULT_GLOBAL_IGNORES_LINE_1 " " \
> + SVN_CONFIG__DEFAULT_GLOBAL_IGNORES_LINE_2
I'd rather not see more double-underscore symbols -- and these
#defines in particular -- in a public header file.
You could put them into a new include/private/ header instead.
The patch looks reasonable to me, other than that. (The ugliness
is intrinsic, unfortunately.)
- application/pgp-signature attachment: stored
Received on Sat Sep 29 01:53:45 2007