> -----Original Message-----
> From: Kamesh Jayachandran
> Sent: Friday, September 28, 2007 4:29 PM
> To: Paul Burba; dev@subversion.tigris.org; kameshj@tigris.org
> Subject: RE: svn commit: r26803 - in trunk/subversion:
> libsvn_client tests/cmdline
>
> >> + {
> >> + svn_merge_range_t *range =
> >> APR_ARRAY_IDX(children_with_mergeinfo, 0,
> >> +
> >> svn_merge_range_t *);
>
> >Hi Kamesh,
>
> >Spotted this while working on issue 2818:
>
> >children_with_mergeinfo is populated with
> svn_client__merge_path_t* not
> >svn_client__merge_path_t *. I assume you meant something like:
>
> >svn_merge_range_t *range = APR_ARRAY_IDX(child->remaining_ranges, 0,
> >svn_merge_range_t *); ?
>
> Thanks for the catch Paul, fixed in r26840.
Hi Kamesh,
I assume you saw my comment regarding slice_remaining_ranges()?
> Regardless, slice_remaining_ranges() is definitely not doing what you
> want. Interestingly, the test suite passes* with it completely
> removed!
It's not immediately obvious to me when slice_remaining_ranges() might
be useful and obviously it isn't being exercised by the test suite at
present. Possibly we could add a test or tweak an existing one to do
this?
My apologies if you were planning on responding to this in another
e-mail.
Paul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 28 22:48:18 2007