[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26768 - trunk/subversion/libsvn_client

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-09-27 20:38:50 CEST

On Mon, 24 Sep 2007, Malcolm Rowe wrote:

> On Mon, Sep 24, 2007 at 01:15:14PM -0700, dlr@tigris.org wrote:
> > +/* Whether CHANGELIST_NAME is NULL, or ENTRY->changelist (which may be
> > + NULL) matches CHANGELIST_NAME. */
> > +#define IS_COMMITTABLE(changelist_name, entry) \
> > + (changelist_name == NULL || \
> > + entry->changelist && strcmp(changelist_name, entry->changelist) == 0)
>
> At this point I'm wondering why this needs to be a macro - why not
> convert to a static function?

That's what I get for touching the code a million times. :-p
A static inline function is completely reasonable -- done in r26808.

  • application/pgp-signature attachment: stored
Received on Thu Sep 27 20:39:09 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.