[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r26802 - trunk/subversion/libsvn_client

From: Paul Burba <pburba_at_collab.net>
Date: 2007-09-27 17:08:33 CEST

Kamesh,

I saw that too almost as soon as I committed it. Quite clever bit of
coding no? :-\ Anyhow, fixed r26804.

Thanks,

Paul

> -----Original Message-----
> From: Kamesh Jayachandran [mailto:kamesh@collab.net]
> Sent: Thursday, September 27, 2007 10:31 AM
> To: dev@subversion.tigris.org; pburba@tigris.org
> Subject: Re: svn commit: r26802 - trunk/subversion/libsvn_client
>
> Hi Paul,
>
>
>
> > URL:
> >
> http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_client/merge.
> > c?pathrev=26802&r1=26801&r2=26802
> >
> ==============================================================
> ================
> > --- trunk/subversion/libsvn_client/merge.c (original)
> > +++ trunk/subversion/libsvn_client/merge.c Thu Sep 27 07:03:02 2007
> > @@ -1533,6 +1533,8 @@
> > && child->absent
> > && svn_path_is_ancestor(target_wcpath, child->path))
> > {
> > + if (notify_b->skipped_paths == NULL)
> > + notify_b->skipped_paths =
> apr_hash_make(notify_b->pool);
> >
> Instead of allocating empty hash table what about
>
> if (notify_b->skipped_paths == NULL)
> apr_hash_set(notify_b->skipped_paths, child->path,
> APR_HASH_KEY_STRING, NULL);
>
>
>
> With regards
> Kamesh Jayachandran
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 27 17:12:28 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.