[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix XFail log test 20

From: Eric Gillespie <epg_at_google.com>
Date: 2007-09-26 18:10:24 CEST

Senthil Kumaran S <senthil@collab.net> writes:

> I am attaching a patch along with this mail to fix log test 20 which is
> marked as XFail test.
>
> There are 3 XFail tests added to log_tests.py in r25175 (by lgo) to test
> the behavior of "svn log -c" command as given in the doc string of these
> tests. Since "-c" option accepts only a single revision number as of
> today (trunk r26785), I ve added this support for "svn log" command.

> Index: subversion/tests/cmdline/log_tests.py
> ===================================================================
> --- subversion/tests/cmdline/log_tests.py (revision 26785)
> +++ subversion/tests/cmdline/log_tests.py (working copy)
> @@ -1159,7 +1159,7 @@
> output, err = svntest.actions.run_and_verify_svn(None, None, [], 'log',
> '-c', 4, repo_url)
> log_chain = parse_log_output(output)
> - check_log_chain(log_chain, [4])
> + check_log_chain(log_chain, [3, 4])

'-c 4' means the change from r3 to r4, so svn log -c 4 really
shouldn't show an entry for r3. That's probably why this is
still an XFail; I looked at it once, but wasn't sure how to get
it to work. Maybe we need to set something in the opt_state
indicating we had a -c not a -r?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 26 18:10:49 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.