Re: svn commit: r26745 - in trunk/subversion: include libsvn_client svn

Hi Karl,

On 9/21/07, kfogel@tigris.org <kfogel@tigris.org> wrote:
> Author: kfogel
> Date: Fri Sep 21 23:44:33 2007
> New Revision: 26745
>
> Log:
> Implement 'svn propset --depth' and 'svn propget --depth'.
>
> This is part of issue #2847 ('depthy APIs') and issue #2844 ('take
> care of "TODO(sd)" comments').
>

A Ruby binding test has been failing since this commit. I can't reproduce via
the command line. Last time this happened I assumed it was the bindings, but
50 commits later it was fixed. So this time I'll try to explain.

Below is an excerpt from the failing test. I've put my best understanding of
what the command line equivalent would be after each line of Ruby, along with
some outputlike stuff...

    ctx.ps(prop_name, prop_value, dir_path)
# svn propset prop_name prop_value wc -R
    ctx.ci(@wc_path)
# svn commit wc -m ""
    assert_equal({
                   dir_uri => prop_value,
                   uri => prop_value,
                 },
                 ctx.pg(prop_name, dir_path))
# svn propget prop_name -R wc
#wc - prop_value
#wc\sample.txt - prop_value
    ctx.up(@wc_path)
# svn update
    ctx.pdel(prop_name, dir_path, false) <== false means non-recursive
# svn propdel prop_name wc
    ctx.ci(@wc_path)
# svn commit wc -m ""
    assert_equal({uri => prop_value}, ctx.pg(prop_name, dir_path))
# svn propget prop_name -R wc
#wc\sample.txt - prop_value

The failure is that there are no properties on the file.

BTW when I was trying to reproduce this on the command line, I found this
tidbit interesting:

  D:\SVN\r26758>svn co file:///D:/SVN/r26758/repos/wc wc
  Checked out revision 1.
  D:\SVN\r26758>echo sdfkj>wc\t.txt

  D:\SVN\r26758>svn add wc\t.txt
  A wc\t.txt

  D:\SVN\r26758>svn commit wc -m ""
  Adding wc\t.txt
  Transmitting file data .
  Committed revision 2.

  D:\SVN\r26758>svn propset pn pv wc -R
  property 'pn' set (recursively) on 'wc'

  D:\SVN\r26758>svn commit wc -m ""
  Sending wc
  svn: Commit failed (details follow):
  svn: Out of date: '/wc' in transaction '2-2'

  D:\SVN\r26758>svn up wc
  At revision 2.

  D:\SVN\r26758>svn commit wc -m ""
  Sending wc
  Sending wc\t.txt

  Committed revision 3.

I was suprised that I couldn't commit the propset until after an update. I
always thought after committing the add of the file that the working copy
would be in sync with the repository. The tests obviously already consider
this.

Thanks,

--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org