[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix uninitialized return value in svn_client_root_url_from_path

From: Daniel L. Rall <dlr_at_finemaltcoding.com>
Date: 2007-09-23 04:31:00 CEST

On Sat, 22 Sep 2007, Stefan Küng wrote:

> Stefan Küng wrote:
> >Hi,
> >
> >If svn_client_root_url_from_path() is called without initializing the
> >return value first to NULL, the function fails without returning an
> >error. This is bad.
> >
> >Attached is a patch which fixes this problem by initializing the return
> >value first - otherwise the check on line 244 in
> >subversion/libsvn_client/util.c fails even though it shouldn't.
>
> Sorry for the noise. Just notice that dlr already fixed this in r26742.

Thanks Stefan -- I ran smack into the same bug. 

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Sun Sep 23 04:31:11 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.