[PATCH] don't "chmod -x" directories

Hi,

I've found a bug in the subversion client, I have briefly discussed it
on irc://irc.freenode.net/#svn, I have written a patch and a test
case. Here is the story of my adventure.

As you probably know, subversion doesn't cope well with files that are
both "svn:special" and "svn:executable". Making sure this never
happens is a one line script:
  find -type l | xargs svn propdel svn:executable

However, after doing this, some of my directories were acting weird
because their executable permission bit was turned off. Now, normally
"svn propdel svn:executable" only calls "chmod -x" on files, never on
directories. However, I was now using propdel on _symlinked_
directories, and this fooled propdel into calling "chmod -x" on them
anyway.

I didn't want that to happen, so I wrote this patch. Enjoy.

[[
Prevent "svn propdel svn:executable symlink-to-dir" from doing "chmod
-x" on the directory
* subversion-1.4.5/subversion/libsvn_wc/props.c
  (svn_wc_prop_set2): don't drop permissions if the target has svn:special
]]

– Samuel Gélineau

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org