Re: svn commit: r26614 - in trunk/subversion/bindings/swig: include ruby/libsvn_swig_ruby ruby/svn

Hi Joe,

2007/9/16, Joe Swatosh <joe.swatosh@gmail.com>:

> > > Author: joeswatosh
> > > Date: Sat Sep 15 12:46:05 2007
> > > New Revision: 26614
> > >
>
>
> >
> > I think it's better that we get a compiler error.
> >
> > If we use a "getter" function and the svn_wc_get_file_t
> > interface is changed, we will not get correct behavior on
> > runtime. I think it's easy to detect incorrect behavior if
> > a compiler reports a error rather than tests report a
> > runtime error.
>
> I know these aren't supposed to change after a release, but we had one
> change that was under development and it was hard for me to find. I
> think this way is better while things might change. After release it
> doesn't matter so much.

Can you find the interface change easily with this change?
If it's true this change is OK.

But It seems that it's not true. Because you didn't write tests
for this change. I'm afraid that the interface change is ignored
and we forget to follow the interface change when release.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org