Re: svn commit: r26614 - in trunk/subversion/bindings/swig: include ruby/libsvn_swig_ruby ruby/svn

Hi Joe,

In <200709151946.l8FJk59j006228@svn2.sjc.collab.net>
  "svn commit: r26614 - in trunk/subversion/bindings/swig: include ruby/libsvn_swig_ruby ruby/svn" on Sat, 15 Sep 2007 12:46:05 -0700,
  joeswatosh@tigris.org wrote:

> Author: joeswatosh
> Date: Sat Sep 15 12:46:05 2007
> New Revision: 26614
>
> Log:
> Follow on to r26471 which merged copy-on-updates branch to trunk. This merely
> gets the existing tests passing, it doesn't actually add new capabilities to
> the bindings. Some TODOs to remember to implement the functionality later.
>
> This is a slightly different implementation than has been used in the past for
> callbacks. Instead of exporting the callback implementation directly I
> created a "getter" function so if the svn_wc_get_file_t interface changes we
> will get a compiler error.

I think it's better that we get a compiler error.

If we use a "getter" function and the svn_wc_get_file_t
interface is changed, we will not get correct behavior on
runtime. I think it's easy to detect incorrect behavior if
a compiler reports a error rather than tests report a
runtime error.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org