Re: [PATCH] svn protocol over windows named pipe

On 9/15/07, $B>>0f(B $B9,<#(B <k@kekyo.net> wrote:
> Hi,
>
> I added the means to access by using the
> named pipe of Windows for SubVersion.
> The following things can be done by using this.
>
> *The direct access protection can be decided
> from the right of access of the repository file by
> using impersonation mode.
> *It becomes a single sign-in by the host under
> the control of ActiveDirectory or Domain Controller.
> *Of course, it is possible to start as service :-)
>
> SubVersion URL scheme is "pipe".
> For instance, it uses it as follows:
>
> svn list pipe://localhost/
> svn list pipe://svntrunk.foo.bar.net:12345/
>
> In the first example, it connects it with the localhost.
> The name of named pipe is "SubVersion3690.
> "When the port number is specified like the second
> example, it becomes "SubVersion12345".
>
> # The user not need learn this thing.
> # It only has to know only URL as usual.
>
> The option such as --pipe and --pipe-with-impersonate
> was added to svnserve.
>
> The method of displaying the error of Windows API
> might have a better procedure.
> (svn_win32_get_error_string)
>
> Please correct it if there is a part not suitable for
> the method.
>

I'd like to see this feature in Subversion. I've looked through your patch:
* svn_win32_get_error_string() isn't needed, since APR formats system
errors for us.
  Just use error code returned by apr_get_os_error() functions or
convert existing errror
  code using APR_FROM_OS_ERROR() macro.
* I prefer something like "svnserve" as pipe name instead of "SubVersion"
* We use only space characters in Subversion. I've noticed several tab
characters in
  your patch, please remove them.
* I'd like passing clients username to Subversions' authz level instead of
  using impersonation mode.

Also I've noticed that you haven't included any log messages with your
patches, per our patch submission guidelines, found here:
http://subversion.tigris.org/hacking.html#patches A good log message
helps reviewers understand the purpose of your patch, and increases
the likelihood that it will be applied. Instructions for writing log
messages can be found here:
http://subversion.tigris.org/hacking.html#log-messages

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org