[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26503 - in trunk/subversion: include libsvn_client libsvn_ra libsvn_ra_local libsvn_ra_neon libsvn_ra_serf libsvn_ra_svn libsvn_repos mod_dav_svn/reports svnserve tests/libsvn_repos

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-09-10 22:45:18 CEST

On Mon, 10 Sep 2007, Ben Collins-Sussman wrote:

> On 9/10/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
>
> > ...but here you parse a boolean ('b') which is verboten. parse_tuple()
> > has no way of specifying "unspecified" when the boolean value is not
> > provided by the client. What you probably want to use is 'B', which
> > gives three values, including SVN_RA_SVN_UNSPECIFIED_NUMBER.
> > subversion/svnserve/serve.c:log_cmd() has some examples.
>
> Thanks Hyrum! I'm glad you looked at that; I don't know the svn
> protocol very well. Does r26511 look right to you?

Looks good to me.

+ send_copyfrom_args = (send_copyfrom_param == SVN_RA_SVN_UNSPECIFIED_NUMBER) ?
+ FALSE : send_copyfrom_param;
              ^^
I did have an urge to add a typecast here, though.

Did you also update the protocol document?

  • application/pgp-signature attachment: stored
Received on Mon Sep 10 22:41:54 2007

This is an archived mail posted to the Subversion Dev mailing list.