[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Submitting a patch for issue #2581

From: Miller, Eric <Eric.Miller_at_amd.com>
Date: 2007-09-06 19:56:46 CEST

Anyone want to review / sponsor this exceedingly small patch?

Checkout of symlinks that had the needs-lock property set would cause an
abort and leave the working copy locked.

Basically I just turned off permission modification for symbolic links.

Thanks!

Eric

--- subversion-1.4.4/subversion/libsvn_subr/io.c 2007-04-25
11:11:40.000000000 -0600
+++ subversion-1.4.4-a/subversion/libsvn_subr/io.c 2007-09-06
11:30:13.000000000 -0600
@@ -1226,7 +1226,13 @@
      by getting the current perms and adding bits
      only on where read perms are granted. If this fails
      fall through to just setting file attributes. */
- status = apr_stat(&finfo, path_apr, APR_FINFO_PROT, pool);
+
+ status = apr_stat(&finfo, path_apr, (APR_FINFO_PROT |
APR_FINFO_LINK), pool);
+
+ /*Skip permision changing for symlinks*/
+ if (finfo.filetype == APR_LNK)
+ return SVN_NO_ERROR;
+
   if (status)
     {
       if (ignore_enoent && APR_STATUS_IS_ENOENT(status))

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 6 19:54:09 2007

This is an archived mail posted to the Subversion Dev mailing list.