Re: [PATCH] Soft-upgrade FSFS repositories by adding new transaction-current file where missing

On Sep 5, 2007, at 5:34 PM, David Glasser wrote:

> On 9/5/07, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
>> This is, of course, impossible. Format 3 FSFS filesystems always
>> have a
>> transaction-current file... unless you're perhaps talking about an
>> older format 3 filesystem that might have existed only in a
>> development
>> version of 1.5.0? :-)
>>
>> While I'm -0 on anything that includes supporting code for unreleased
>> versions of the filesystem, I'm -1 on anything that performs write
>> operations on a filesystem that we aren't necessarily writing to
>> -- FSFS
>> filesystems should be readable from read-only media, and the below
>> won't
>> be (you'd need to ignore EACCESS, for one).
>
> +1 to everything Malcolm said.

Ditto here.

I deliberately wanted to reduce the number of system calls to support
the new feature, so made the transaction-current a part of the format
3 fsfs format. I didn't like the code in previous versions that
always tries to create a file (I forgot which one) instead of just
assuming it's there.

Regards,
Blair

-- 
<blair@orcaware.com>
Subversion training, consulting and support
http://www.orcaware.com/training/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org