Re: [PATCH] serf/ra_serf: add cansend callback to stop writing requests untill authn handshake is finished

On 7/24/07, Lieven Govaerts <lgo@mobsol.be> wrote:
> The patch for serf adds the callback and uses it in
> context.c/write_connection. The callback can be used for all connection
> based authentication protocols, the NTLM part is the first
> implementation using it.

The serf side of the patch looks fine.

I don't know (care?) enough about the NTLM part to comment on how you
are using it - but I can see that an app may want to limit serf's
aggressiveness a little bit.

> The serf patch changes the serf_connection_create function declaration,
> I suppose there's no API compatibility guarantee before serf 1.0?

I've been working off the assumption that there is - just to make it
slightly easier on folks who may have serf packaged in their OS. =)

To give you an idea, look at what I did in libsvn_ra_serf/util.c:

#if SERF_VERSION_AT_LEAST(0,1,1)
....SSL client callback stuff...
#endif

I'd recommend doing the same for anything that requires the new
prototype. NTLM is a specific corner case, so not everyone may care
about it and justify them upgrading their serf installs.

My $.02. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 29 09:19:58 2007