[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26341 - trunk/subversion/libsvn_wc

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2007-08-28 14:04:09 CEST

On 8/28/07, C. Michael Pilato <cmpilato@collab.net> wrote:
> dionisos@tigris.org wrote:
> > Author: dionisos
> > Date: Mon Aug 27 13:15:37 2007
> > New Revision: 26341
> >
> > Log:
> > Replace svn_path_uri_encode()/svn_path_join() pairs with
> > svn_path_url_add_component() which is designed to do the same thing.
>
> If fully obeying the API constraints, path_join + uri_encode =
> url_add_component only when joining and encoding a single path component.
> svn_path_url_add_component's docstring begins, "Extend @a url by a single @a
> component, URI-encoding that @a component..." But really, this is a
> somewhat unnecessary restriction, and perhaps we should just update that
> docstring to indicate that multi-component paths -- if using URL-style
> component separators (/) -- are permitted.

I think I might have been too terse, because an it happens the code I
changed only appends the basename component to a parent url path.
(Meaning that it doesn't violate the API).

HTH,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 28 14:01:30 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.