[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix XFail merge test 62

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2007-08-24 20:06:57 CEST

On Aug 23, 2007, at 5:36 AM, Senthil Kumaran S wrote:

> @@ -3507,11 +3511,10 @@
> _("'%s' has no URL"),
> svn_path_local_style(source2, pool));
>
> + /* Initialize the administrative area lock depth to -1 */
> SVN_ERR(svn_wc_adm_probe_open3(&adm_access, NULL, target_wcpath,
> - ! dry_run,
> - SVN_DEPTH_TO_RECURSE(depth) ?
> -1 : 0,
> - ctx->cancel_func, ctx->cancel_baton,
> - pool));
> + ! dry_run, -1, ctx->cancel_func,
> + ctx->cancel_baton, pool));
>
> SVN_ERR(svn_wc__entry_versioned(&entry, target_wcpath,
> adm_access, FALSE,
> pool));
> @@ -3685,11 +3688,10 @@
> svn_config_t *cfg;
> const char *wc_repos_root;
>
> + /* Initialize the administrative area lock depth to -1 */
> SVN_ERR(svn_wc_adm_probe_open3(&adm_access, NULL, target_wcpath,
> - ! dry_run,
> - SVN_DEPTH_TO_RECURSE(depth) ?
> -1 : 0,
> - ctx->cancel_func, ctx->cancel_baton,
> - pool));
> + ! dry_run, -1, ctx->cancel_func,
> + ctx->cancel_baton, pool));

You can leave out these additional comments. If you were to add them
(and as I mentioned, I think they're unnecessary in this case), you'd
want to indicate that you were locking the entire WC under the sub-
tree target_wcpath.

- Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 24 19:57:47 2007

This is an archived mail posted to the Subversion Dev mailing list.