Re: [PATCH] Ruby bindings follow on to r26222

Hi,

Uhmm... That's strange...
Anyway, please commit.

Thanks,

--
koyu
In <ae6cb1100708232153x20a2cev7b6745e325c304e7@mail.gmail.com>
  "Re: [PATCH] Ruby bindings follow on to r26222" on Thu, 23 Aug 2007 21:53:38 -0700,
  "Joe Swatosh" <joe.swatosh@gmail.com> wrote:
> On 8/23/07, Kouhei Sutou <kou@cozmixng.org> wrote:
> > Hi,
> >
> > In <ae6cb1100708222205r4578b327ybe20053468104b2@mail.gmail.com>
> >  "[PATCH] Ruby bindings follow on to r26222" on Wed, 22 Aug 2007 22:05:26 -0700,
> >  "Joe Swatosh" <joe.swatosh@gmail.com> wrote:
> >
> > > [[[
> > > Follow on to r26222 which added a depth argument to svn_repos_begin_report2.
> > >
> > > * subversion/bindings/swig/ruby/svn/repos.rb:
> > >  (Svn::Repos::ReposCore#report2) forwarded the already existing depth argument
> > >  to Svn::Repos#begin_report_2.
> > > ]]]
> > >
> > > Index: subversion/bindings/swig/ruby/svn/repos.rb
> > > ===================================================================
> > > --- subversion/bindings/swig/ruby/svn/repos.rb  (revision 26229)
> > > +++ subversion/bindings/swig/ruby/svn/repos.rb  (working copy)
> > > @@ -103,7 +103,7 @@
> > >          authz_read_func ||= @authz_read_func
> > >          args = [
> > >            rev, self, fs_base, target, tgt_path, text_deltas,
> > > -          ignore_ancestry, editor, authz_read_func,
> > > +          depth, ignore_ancestry, editor, authz_read_func,
> > >          ]
> > >          report_baton = Repos.begin_report2(*args)
> > >          setup_report_baton(report_baton)
> >
> > Do we still need to the following line?
> >
> >  report_baton.set_path("", rev, false, nil, depth)
> >
> > If the line is not needed, please remove that and commit.
> >
> >
> > Thanks,
> > --
> > kou
> >
> 
> With out the line we errored:
> +++++++++
> D:\SVN\src-trunk\subversion\bindings\swig\ruby>test\run-test.rb
> Loaded suite .
> Started
> ................................................................................F...........................................................
> ....................E........................................
> Finished in 901.967 seconds.
> 
>   1) Failure:
> test_merge_info_to_s(SvnCoreTest)
> [D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_core.rb:749]:
> <"/trunk:5*,7*,9-13*"> expected but was
> <"/trunk:5,7,9-13">.
> 
>   2) Error:
> test_report2(SvnReposTest):
> Svn::Error::ReposBadRevisionReport:
> D:\SVN\src-trunk\subversion\libsvn_repos\reporter.c:1084 Invalid
> report for top level of working copy
>     D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
> `svn_repos_finish_report'
>     D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
> `finish_report'
>     D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/repos.rb:399:in
> `finish_report'
>     D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/repos.rb:112:in `report2'
>     D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_repos.rb:408:in
> `test_report2'
>     D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_repos.rb:380:in
> `assert_report'
>     D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_repos.rb:400:in
> `test_report2'
> 
> 201 tests, 1192 assertions, 1 failures, 1 errors
> ----------
> 
> The failure already existed.  I'm not sure what to make of this:
> +++++++++
> 
> D:\SVN\src-trunk\subversion\bindings\swig\ruby>ruby test\run-test.rb
> Loaded suite .
> Started
> ................................................................................F...........................................................
> .............................................................
> Finished in 985.207 seconds.
> 
>   1) Failure:
> test_merge_info_to_s(SvnCoreTest)
> [D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_core.rb:749]:
> <"/trunk:5*,7*,9-13*"> expected but was
> <"/trunk:5,7,9-13">.
> 
> 201 tests, 1193 assertions, 1 failures, 0 errors
> 
> D:\SVN\src-trunk\subversion\bindings\swig\ruby>test\run-test.rb
> test\test_core.rb -n test_merge_info_to_s
> Loaded suite test_core.rb
> Started
> .
> Finished in 2.424 seconds.
> 
> 1 tests, 2 assertions, 0 failures, 0 errors
> 
> D:\SVN\src-trunk\subversion\bindings\swig\ruby>test\run-test.rb
> test\test_core.rb
> Loaded suite test_core.rb
> Started
> ............................................
> Finished in 84.802 seconds.
> 
> 44 tests, 145 assertions, 0 failures, 0 errors
> 
> ----------
> The test passes for me except when run as part of the entire suite.
> 
> Not sure where to go next.
> --
> Joe
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
> 
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org