Re: [PATCH] Update progress while ra-neon spools text delta

Daniel Rall <dlr@finemaltcoding.com> writes:

> > @@ -1138,6 +1143,8 @@
> > svn_stream_t *stream;
> >
> > baton = apr_pcalloc(file->pool, sizeof(*baton));
> > + baton->ras = file->cc->ras;
> > + baton->pool = pool;
> > file->put_baton = baton;
> >
> > if (base_checksum)
>
> Should we use file->pool instead of the pool parameter passed to
> commit_apply_txdelta()? I think baton's useful lifetime is that of
> commit_apply_txdelta()'s stack frame, but since it's allocated out of
> file->pool rather than pool, I think it would be more correct unless
> we document that put_baton_t.pool should be used only for temporary
> allocations.

We talked about this on IRC. svn_delta.h does not describe the
pool passed to apply_textdelta, but it seems to me that the
svn_stream_create and svn_txdelta_to_svndiff calls here should
also be using file->pool, not the passed-in pool. Or they should
all be using the passed-in pool, I'm not sure; it seems bogus
that some use one and some the other. I suppose it depends
whether the driver clears this pool directly after the call.

I'm testing with Dan's suggested change now, looks good, will
commit soon.

Thanks.

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org