[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Ruby bindings follow on to r26222

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2007-08-23 13:18:05 CEST

Hi,

In <ae6cb1100708222205r4578b327ybe20053468104b2@mail.gmail.com>
  "[PATCH] Ruby bindings follow on to r26222" on Wed, 22 Aug 2007 22:05:26 -0700,
  "Joe Swatosh" <joe.swatosh@gmail.com> wrote:

> [[[
> Follow on to r26222 which added a depth argument to svn_repos_begin_report2.
>
> * subversion/bindings/swig/ruby/svn/repos.rb:
> (Svn::Repos::ReposCore#report2) forwarded the already existing depth argument
> to Svn::Repos#begin_report_2.
> ]]]
>
> Index: subversion/bindings/swig/ruby/svn/repos.rb
> ===================================================================
> --- subversion/bindings/swig/ruby/svn/repos.rb (revision 26229)
> +++ subversion/bindings/swig/ruby/svn/repos.rb (working copy)
> @@ -103,7 +103,7 @@
> authz_read_func ||= @authz_read_func
> args = [
> rev, self, fs_base, target, tgt_path, text_deltas,
> - ignore_ancestry, editor, authz_read_func,
> + depth, ignore_ancestry, editor, authz_read_func,
> ]
> report_baton = Repos.begin_report2(*args)
> setup_report_baton(report_baton)

Do we still need to the following line?

  report_baton.set_path("", rev, false, nil, depth)

If the line is not needed, please remove that and commit.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 23 13:15:46 2007

This is an archived mail posted to the Subversion Dev mailing list.