[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26210 - in branches/svnpatch-diff/subversion: include libsvn_client libsvn_wc svn

From: Charles Acknin <charlesacknin_at_gmail.com>
Date: 2007-08-21 23:27:08 CEST

On 8/20/07, David Glasser <glasser@davidglasser.net> wrote:
> Hey Charles! I don't have a chance to do full review of this patch
> (26 hours until thesis deadline), but just wondering --- what did you
> end up deciding about applying text deltas? Looks like from below
> that you're going for the "apply deltas based on the gzipped block,
> ignoring the unidiff" route... is that true? If so you should
> probably update the docs that talk about /usr/bin/patch...

Hey David, you're right I went this way. For two reasons. First, I
seem to recall someone -- was it you? -- mentioned on #svn-dev that
/usr/bin/patch wasn't going to be a great choice for win-box folks.
Second, it's fine -- for now -- to use an external tool to apply the
(svn)patch. Definitely, I think we have to talk further about this
point. Are we going to implement our own unidiff parser? I don't
know yet, but we may want to reach consensus here before we take a --
rather decisive -- decision. So yeah, I will update docstrings.

BTW, sorry that a few of my commits were rather large; I wish I had
sent little chunks every now and then so that code-review was a lot

Oh, and have fun with your thesis. (Luck has nothing to do with these
kinda things, right? :-)


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 21 23:25:11 2007

This is an archived mail posted to the Subversion Dev mailing list.