[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26220 - in branches/copy-on-update/subversion: libsvn_repos libsvn_wc

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-08-21 21:46:08 CEST

Ben Collins-Sussman wrote:
> This is why I love committing to branches. Feedback already!
>
> I've added an authz check as Vlad suggested...
>
>
> On 8/21/07, C. Michael Pilato <cmpilato@collab.net> wrote:
>>>> + if (closest_copy_root != NULL)
>>>> + {
>>>> + /* If the destination of the copy event is the same path as
>>>> + o_path, then we've found something interesting that should
>>>> + have 'copyfrom' history. */
>>>> + if (strcmp(closest_copy_path + 1, o_path) == 0)
>> I don't think other processes permit this to happen, but this could should
>> be able to handle the possibility of closest_copy_path being "/". Won't
>> strcmp() choke here in that case?
>
> How could the destination of a copy event be '/'?

You've missed the point.

As I said, "I don't think other processes permit this to happen" -- that is,
today, the destination cannot be the root directory. But that needn't
always be the case.

It turns out not to matter, as I was suffering a think-O anyway: "/" + 1 is
"", not NULL -- strcmp() will be just fine.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Tue Aug 21 21:43:45 2007

This is an archived mail posted to the Subversion Dev mailing list.