[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26195 - in trunk: . subversion/include subversion/libsvn_subr subversion/tests/libsvn_subr

From: Blair Zajac <blair_at_orcaware.com>
Date: 2007-08-20 18:04:44 CEST

On Aug 20, 2007, at 8:54 AM, Joe Swatosh wrote:

> On 8/19/07, Blair Zajac <blair@orcaware.com> wrote:
>> Joe Swatosh wrote:
>>> Hi Blair
>>>
>>> On 8/19/07, blair@tigris.org <blair@tigris.org> wrote:
>
>>
>> Thanks for the patch. Applied in r26200.
>>
>> And this was with gcc 4.0.1 (C, not C++). Need to put a -std
>> command line
>> option in my build.
>>
>
> That would do it.
>
> I'm still getting my bearings. Since this isn't in my access area I
> wanted to be conservative, but should I have considered this an
> "obvious fix?"

Yes, I believe that would qualify as an obvious fix.

But I wouldn't qualify removing unused variables or even fixing
comment/code inconsistencies as obvious fixes.

Regards,
Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 20 18:02:31 2007

This is an archived mail posted to the Subversion Dev mailing list.