Re: Trunk JavaHL is not building after merge from blame branch

On 8/18/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
> > Also, Hyrum, I thought you were going to make BlameCallbackImpl
> > implement both the old and new interface?
>
> I remember talking about that, but now it makes sense to have
> BlameCallbackImpl just implement the BlameCallback2 interface. Both of
> them are new with 1.5, so it doesn't make much sense to have
> BlameCallbackImpl implement a now obsolete interface when it doesn't
> have any compatibility needs.

I agree, except it isn't doing that. It is only implementing BlameCallback.

> > Finally, in the new interface, which fields have the info from the
> > "original" change? I assume the field names with "merged" in them
> > contain the info from when the line was merged, and the other fields
> > from when it originated?
>
> The doc string in BlameCallback2 has been updated to reflect which
> arguments represent the merged revisions, and which ones are the
> original revisions. Does that help with the confusion?

I ran it in debug before you updated. I am all set.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org