Re: If no such changelist, show we error?

On 8/17/07, Karl Fogel <kfogel@red-bean.com> wrote:
> The following IRC conversation says it all:
>
> <kfogel> Is it a deliberate decision that 'svn commit -m logmsg
> --changelist NON_EXISTENT_CHANGELIST_NAME' does nothing?
> (It doesn't show any error, and it doesn't commit anything,
> even if there are local mods, though of course those local
> mods are not in the named changelist, since it doesn't exist.)
>
> <kfogel> This behavior is true even if you pass --keep-changelist
>
> <epg> i vote bug; it should error with "no such changelist"
>
> <kfogel> epg: I agree.
>
> <kfogel> Hmm, I'll ask dev@, just in case there was some esoteric
> reason why this behavior was deliberate.

None of the other --changelist commands work that way. (They use the
svn_client_get_changelist call and explicitly check to see if the
changelist is empty.) While commit is implemented differently, I'd
certainly expect this to be a bug. I'd hope to see either no output
or a warning if you call "svn ci --changelist foo" where foo has
elements but has no committables, and an error if you call "svn ci
--changelist footypo" where footypo has no elements at all.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org