Re: [PATCH] Last two ra callbacks for Python binding

Eric Gillespie <epg@pretzelnet.org> writes:

> structure, but the progress wrapper has some problem. If I use
> make_ob_pool as for the other ra callbacks, I get a segfault.
> According to gdb, pool is NULL, but I verified it is not by
> adding a test block that apr_pstrdups and prints a string. I
> can't figure out what's wrong.

Dan Christian found my problem:

> + if ((result = PyObject_CallFunction(py_callback,
> + (char *)"ll", progress, total)) == NULL)
> +/* Why does this segfault? */
> +/* (char *)"llO&", progress, total, */
> +/* make_ob_pool, pool)) == NULL) */

Whoops, apr_off_t is 64 bits! That should be LL. Is that always
the case? Should I hard-code LL like that, or use a different
format string depending on sizeof(progress)?

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org