[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn trunk r26069: FAIL (win32-xp VS2005)

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2007-08-14 20:09:30 CEST

On 8/14/07, Daniel Rall <dlr@finemaltcoding.com> wrote:
>
> On Aug 14, 2007, at 2:38 AM, Lieven Govaerts wrote:
>
> > Quoting Erik Huelsmann <ehuels@gmail.com>:
> >
> >> These breakage failures are caused by code-before-declaration errors
> >> on my side; the first in three_way_merge() [line 164], the other in
> >> two_way_diff() [line 257].
> >>
> >> In both cases, the line 'options = options ? options ...' needs to be
> >> moved down below the immediate next block which declares
> >> svn_string_t*
> >> variables.
> >>
> >> I'm at work, so, if someone could commit this fix, buildbot can start
> >> passing again.
> >>
> >> Thanks in advance!
> >>
> >> Bye,
> >>
> >> Erik.
> >>
> >> PS: Is there something in my CFLAGS I can set to prevent this kind
> >> of error?
> >
> > Adding -std=c89 should have that effect.
>
> Is there any particular reason why we don't add this to Makefile by
> default?

Thanks for asking, because I was wondering the same thing. I think we
should (when we detect GCC, that is).

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 14 20:07:29 2007

This is an archived mail posted to the Subversion Dev mailing list.