[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Refactor code for --auto-props and --no-auto-props mutual exclusion

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2007-08-14 09:07:46 CEST

> I don't see any instance of code-before-decl here ('err' is already
> declared), but do watch out for tabs -- those should be spaces
> instead, so the indentation will come out right.
>

+ if (opt_state.autoprops && opt_state.no_autoprops)
+ {
+ err = svn_error_create(SVN_ERR_CL_MUTUALLY_EXCLUSIVE_ARGS, NULL,
+ _("--auto-props and --no-auto-props are "
+ "mutually exclusive"));
+ return svn_cmdline_handle_exit_error(err, pool, "svn: ");
+ }
+
       const char *mimetypes_file;
       svn_config_get(cfg, &mimetypes_file,
                      SVN_CONFIG_SECTION_MISCELLANY,

See the 'new if block' before the '*mimetypes_file' declaration.

So as per your review comments if we take this block of check(with
proper indentation) outside 'svn_cl__import' and 'svn_cl__add' this
problem goaway.

With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 14 09:04:29 2007

This is an archived mail posted to the Subversion Dev mailing list.