[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Refactor code for --auto-props and --no-auto-props mutual exclusion

From: Senthil Kumaran S <senthil_at_collab.net>
Date: 2007-08-14 08:04:29 CEST

Hi,

Karl Fogel wrote:
> declared), but do watch out for tabs -- those should be spaces
> instead, so the indentation will come out right.

I ve corrected it in the new patch.

> Also, why make it conditional on svn_cl__add or svn_cl__import? I
> would think autoprops and no_autoprops would be mutually exclusive in
> any conceivable universe :-). If so, it makes sense to check for the
> exclusivity outside any other conditional, since the check is cheap.

As per the above suggestion by Karl, I am reattaching the new updated
patch along with this mail.

[[[
Follow-up to refactoring r26007

    * subversion/svn/main.c
      (main): Check for sanity of argument combinations only once after
       parsing all the arguments for --auto-props and --no-auto-props.

Patch by: Senthil Kumaran <senthil@collab.net>
Suggested by: kfogel
]]]

PS: As per hwright's comments am including my log message inline :)

Thank You.

--
Senthil Kumaran S
http://www.stylesen.org/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Aug 14 08:02:43 2007

This is an archived mail posted to the Subversion Dev mailing list.