[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26052 - trunk/subversion/libsvn_client

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-08-13 21:04:32 CEST

David James wrote:
> On 8/13/07, hwright@tigris.org <hwright@tigris.org> wrote:
...
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_client/copy.c?pathrev=26052&r1=26051&r2=26052
>> ==============================================================================
>> --- trunk/subversion/libsvn_client/copy.c (original)
>> +++ trunk/subversion/libsvn_client/copy.c Mon Aug 13 08:13:16 2007
>> @@ -1942,10 +1942,11 @@
>> subpool);
>> }
>>
>> - if (commit_info)
>> - *commit_info_p = svn_commit_info_dup(commit_info, pool);
>> - else
>> - *commit_info_p = commit_info;
>> + if (commit_info_p != NULL)
>> + if (commit_info)
>> + *commit_info_p = svn_commit_info_dup(commit_info, pool);
>> + else
>> + *commit_info_p = commit_info;
>
> Thanks for the fix, Hyrum. I believe this fix is correct, but I find
> it hard to parse because of the dangling else. Could you add some
> braces around the outer if statement here to make the code a bit more
> clear?

Mike beat me to it r26056.

-Hyrum

Received on Mon Aug 13 21:03:15 2007

This is an archived mail posted to the Subversion Dev mailing list.