[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26049 - trunk/subversion/libsvn_diff

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2007-08-13 09:38:27 CEST

On 8/13/07, Joe Swatosh <joe.swatosh@gmail.com> wrote:
> Hi
>
> On 8/12/07, dionisos@tigris.org <dionisos@tigris.org> wrote:
> > Author: dionisos
> > Date: Sun Aug 12 14:25:04 2007
> > New Revision: 26049
> >
> > Log:
> > Make svn_diff__normalize_buffer() aggressively try *not* to copy data
> > (instead returning a pointer to already normalized input), but when it does,
> > make it use a specified output buffer.
> >
> > This change enables callers to pass original content (which should
> > not be modified). A required change to make in-memory diffing support
> > normalization.
> >
> >
>
> >
>
> This change also causes new Ruby bindings test failures on windows:
>
> 1) Failure:
> test_diff_merge(SvnCoreTest)
> [D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_core.rb:482]:
> <"\r\n b\r\n\r\nd\r\ne\r\n"> expected but was
> <"\r\n b\r\n\r\nd\r\n e\r\n">.

Thanks for the report. I'm indeed expecting problems with test with
leading whitespace in the file. I hope to have it fixed tonight.

bye,

Erik.
PS: I have a small reproduction recipe for inclusion into
diff-diff3-test.c to prevent future problems of the same type.

> 2) Failure:
> test_diff_unified(SvnCoreTest)
> [D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_core.rb:404]:
> <"--- (orig)\r\n+++ (mod)\r\n@@ -1,3 +1,3 @@\r\n a\r\n-b\r\n+\r\n
> c\r\n"> expected but was
> <"--- (orig)\r\n+++ (mod)\r\n@@ -1,3 +1,3 @@\r\n- a\r\n-b\r\n-
> c\r\n+a\r\n+\r\n+ c\r\n">.
>
> --
> Joe
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 13 09:36:22 2007

This is an archived mail posted to the Subversion Dev mailing list.