[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra-dav no longer propagates revprop errors

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2007-08-04 03:25:45 CEST

Eric Gillespie <epg@pretzelnet.org> writes:

> > > Log message and patch for a unit test follow. Errors from the
> > > pre-revprop-change hook no longer propagate over ra-dav. Still
> > > works over ra-local and ra-svn; I haven't tested serf. I don't

Replying to myself one more time to say that, yes, serf does
share the problem:

1 cmdline% ./prop_tests.py --url http://localhost:23039 --http-library serf 12
EXPECTED STDERR (regexp):
.*pre-revprop-change
ACTUAL STDERR:
EXCEPTION: SVNLineUnequal
FAIL: prop_tests.py 12: set, get, and delete a revprop change

> > > really have the time to dig into this, so I'm hoping some ra-dav
> > > expert will save me yet again from having to enter that part of
> > > Subversion for the first time ;->.
> > >
> > > I first noticed this problem with my r75148 build, so the bug is
> > > at least that old.
>
> Obviously I was mistaken with this revision number, but I played
> around a bit and learned something. ra-dav has not shown error
> output from pre-revprop-change in a very long time; it doesn't
> even show it with 1.4.0. All it shows is:
>
> subversion/libsvn_ra_dav/fetch.c:1906: (apr_err=175002)
> svn: DAV request failed; it's possible that the repository's pre-revprop-change hook either failed or is non-existent
> subversion/libsvn_ra_dav/props.c:1104: (apr_err=175008)
> svn: At least one property change failed; repository is unchanged
>
> ra-svn is fine on 1.4.0, and as I said earlier, still fine on
> trunk today. It was in r22712 that ra-dav stopped showing any
> indication at all that the revprop change didn't go through.
>
> > While we're here: Why is the SVN_ERR_REPOS_DISABLED_FEATURE
> > error not marshaled over? I'm looking at mod_dav_svn/deadprops.c
> > save_value and it looks it should be:
> >
> > serr = svn_repos_fs_change_rev_prop3
> > ...
> > if (serr != NULL)
> > return dav_svn__convert_err(serr, HTTP_INTERNAL_SERVER_ERROR,
> > NULL,
> > db->resource->pool);
> >
> > But apparently it isn't. ra-svn has no trouble marshaling it
> > across. It would be handy for applications not to have to check
> > look for one error code for ra-dav and one for everything else.
> >
> > This is not the only case where ra-dav is the oddball in having
> > its own error code; I've worked around a few others in the past.
> > One day I should make a list. And one day I should look to see
> > if ra-serf has the same problem...
>
> Anyone?
>
> --
> Eric Gillespie <*> epg@pretzelnet.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 4 03:24:10 2007

This is an archived mail posted to the Subversion Dev mailing list.