[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra-dav no longer propagates revprop errors

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2007-08-02 01:10:06 CEST

Eric Gillespie <epg@pretzelnet.org> writes:

> Log message and patch for a unit test follow. Errors from the
> pre-revprop-change hook no longer propagate over ra-dav. Still
> works over ra-local and ra-svn; I haven't tested serf. I don't
> really have the time to dig into this, so I'm hoping some ra-dav
> expert will save me yet again from having to enter that part of
> Subversion for the first time ;->.
>
> I first noticed this problem with my r75148 build, so the bug is
> at least that old.

While we're here: Why is the SVN_ERR_REPOS_DISABLED_FEATURE
error not marshaled over? I'm looking at mod_dav_svn/deadprops.c
save_value and it looks it should be:

        serr = svn_repos_fs_change_rev_prop3
...
  if (serr != NULL)
    return dav_svn__convert_err(serr, HTTP_INTERNAL_SERVER_ERROR,
                                NULL,
                                db->resource->pool);

But apparently it isn't. ra-svn has no trouble marshaling it
across. It would be handy for applications not to have to check
look for one error code for ra-dav and one for everything else.

This is not the only case where ra-dav is the oddball in having
its own error code; I've worked around a few others in the past.
One day I should make a list. And one day I should look to see
if ra-serf has the same problem...

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 2 01:08:35 2007

This is an archived mail posted to the Subversion Dev mailing list.