Running 1.4.x tests against trunk

I think we should be able to run the tests in the 1.4.x branch with a
trunk server and have them pass. (The reverse is a trickier issue,
though arguably we should have a way of marking tests as "XFAIL unless
server is >= 1.5".)

I just ran the 1.4.x tests against a trunk svnserve. I had the
following failures:

FAIL: commit_tests.py 34: post commit hook failure case testing
FAIL: update_tests.py 18: non-recursive update
FAIL: switch_tests.py 11: non-recursive switch
FAIL: diff_tests.py 6: non-recursive behaviour

Most of these are issues with the attempt to make the new depth
support emulate the old -N support. They can indicate a two different
things:

 (a) They should be passing, and the backward-compatability code on
     trunk needs to be fixed in order to make them pass.

 (b) The trunk behavior is different, but -N was never well defined and
     it's OK if we change its behavior a little bit.

In my opinion, even if we do accept a little bit of changed behavior
for -N, we should change any tests on the 1.4.x that fail for type (b)
reasons to make them pass against both 1.4.x and trunk servers. That
way, they won't mask type (a) errors, which are serious.

(The one non-depth failure above, commit #34, is definitely of type
(b): an error message changed. I think we should change the expected
error to be a regexp that matches both versions. Should I just do
this on trunk and propose it for backport? Or should I do it on a
branch from 1.4.x?)

--dave

Oh, in case people want to fix those specific bugs, here is the
tests.log output:

CMD: svnadmin "create" "svn-test-work/repositories/commit_tests-34"
"--bdb-txn-nosync" <TIME = 0.098623>
CMD: svnadmin dump "svn-test-work/local_tmp/repos" | svnadmin load
"svn-test-work/repositories/commit_tests-34" <TIME = 0.020133>
CMD: svn "co" "--username" "jrandom" "--password" "rayjandom"
"svn://127.0.0.1/svn-test-work/repositories/commit_tests-34"
"svn-test-work/working_copies/commit_tests-34" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.766049>
CMD: svn "ci" "-m" "log msg"
"svn-test-work/working_copies/commit_tests-34/iota" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.991807>
EXPECTED STDOUT:
Sending svn-test-work/working_copies/commit_tests-34/iota
Transmitting file data .
Committed revision 2.

Warning: 'post-commit' hook failed with error output:
Post-commit hook failed
ACTUAL STDOUT:
Sending svn-test-work/working_copies/commit_tests-34/iota
Transmitting file data .
Committed revision 2.

Warning: 'post-commit' hook failed (exited with a non-zero exitcode of
1). The following error output was produced by the hook:
Post-commit hook failed
EXCEPTION: SVNLineUnequal
FAIL: commit_tests.py 34: post commit hook failure case testing

CMD: svnadmin "create" "svn-test-work/repositories/update_tests-18"
"--bdb-txn-nosync" <TIME = 0.092524>
CMD: svnadmin dump "svn-test-work/local_tmp/repos" | svnadmin load
"svn-test-work/repositories/update_tests-18" <TIME = 0.041797>
CMD: svn "co" "--username" "jrandom" "--password" "rayjandom"
"svn://127.0.0.1/svn-test-work/repositories/update_tests-18"
"svn-test-work/working_copies/update_tests-18" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.399487>
CMD: svn "ci" "--username" "jrandom" "--password" "rayjandom" "-m"
"log msg" "svn-test-work/working_copies/update_tests-18"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.989697>
CMD: svn "status" "-v" "-u" "-q" "--username" "jrandom" "--password"
"rayjandom" "svn-test-work/working_copies/update_tests-18"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.130860>
CMD: svn "up" "-r" "1" "svn-test-work/working_copies/update_tests-18"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.853934>
CMD: svn "status" "-v" "-u" "-q" "--username" "jrandom" "--password"
"rayjandom" "svn-test-work/working_copies/update_tests-18"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.134054>
CMD: svn "up" "-N" "svn-test-work/working_copies/update_tests-18/A"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.850439>
=============================================================
Expected __SVN_ROOT_NODE and actual __SVN_ROOT_NODE are different!
=============================================================
EXPECTED NODE TO BE:
=============================================================
 * Node name: __SVN_ROOT_NODE
    Path: __SVN_ROOT_NODE
    Contents: None
    Properties: {}
    Attributes: {}
    Children: 1
=============================================================
ACTUAL NODE FOUND:
=============================================================
 * Node name: __SVN_ROOT_NODE
    Path: __SVN_ROOT_NODE
    Contents: None
    Properties: {}
    Attributes: {}
    Children: is a file.
Unequal Types: one Node is a file, the other is a directory
EXCEPTION: SVNTreeUnequal
FAIL: update_tests.py 18: non-recursive update

CMD: svnadmin "create" "svn-test-work/repositories/switch_tests-11"
"--bdb-txn-nosync" <TIME = 0.082934>
CMD: svnadmin dump "svn-test-work/local_tmp/repos" | svnadmin load
"svn-test-work/repositories/switch_tests-11" <TIME = 0.017627>
CMD: svn "co" "--username" "jrandom" "--password" "rayjandom"
"svn://127.0.0.1/svn-test-work/repositories/switch_tests-11"
"svn-test-work/working_copies/switch_tests-11" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.541793>
CMD: svn "co" "svn://127.0.0.1/svn-test-work/repositories/switch_tests-11/A"
"svn-test-work/working_copies/switch_tests-11/wc2" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.991065>
CMD: svn "mkdir" "-m" ""
"svn://127.0.0.1/svn-test-work/repositories/switch_tests-11/branch"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.193319>
CMD: svn "cp" "-m" ""
"svn://127.0.0.1/svn-test-work/repositories/switch_tests-11/A"
"svn://127.0.0.1/svn-test-work/repositories/switch_tests-11/branch/version1"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.157763>
CMD: svn "up" "svn-test-work/working_copies/switch_tests-11"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.647374>
CMD: svn "add" "svn-test-work/working_copies/switch_tests-11/branch/version1/newfile"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.455579>
CMD: svn "ci" "-m" "" "svn-test-work/working_copies/switch_tests-11"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.547501>
CMD: svn "switch" "-N"
"svn://127.0.0.1/svn-test-work/repositories/switch_tests-11/branch/version1"
"svn-test-work/working_copies/switch_tests-11/wc2" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.996506>
CMD: svn "info" "svn-test-work/working_copies/switch_tests-11/wc2/B"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.097804>
CMD: svn "info" "svn-test-work/working_copies/switch_tests-11/wc2/C"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.084961>
CMD: svn "info" "svn-test-work/working_copies/switch_tests-11/wc2/D"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.093532>
CMD: svn "info" "svn-test-work/working_copies/switch_tests-11/wc2/mu"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.093333>
CMD: svn "info"
"svn-test-work/working_copies/switch_tests-11/wc2/newfile"
"--config-dir" "/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.084958>
EXPECTED STDERR:
ACTUAL STDERR:
svn-test-work/working_copies/switch_tests-11/wc2/newfile: (Not a
versioned resource)

EXCEPTION: SVNLineUnequal
FAIL: switch_tests.py 11: non-recursive switch

CMD: svnadmin "create" "svn-test-work/repositories/diff_tests-6"
"--bdb-txn-nosync" <TIME = 0.077100>
CMD: svnadmin dump "svn-test-work/local_tmp/repos" | svnadmin load
"svn-test-work/repositories/diff_tests-6" <TIME = 0.009219>
CMD: svn "co" "--username" "jrandom" "--password" "rayjandom"
"svn://127.0.0.1/svn-test-work/repositories/diff_tests-6"
"svn-test-work/working_copies/diff_tests-6" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.350132>
CMD: svn "up" "-r" "HEAD" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.992110>
CMD: svn "diff" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.090839>
CMD: svn "diff" "-r" "HEAD" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.117036>
CMD: svn "ci" "-m" "log msg" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.788668>
CMD: svn "up" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.995329>
CMD: svn "diff" "-r" "1" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.142084>
CMD: svn "diff" "-r" "1"
"svn-test-work/working_copies/diff_tests-6/A/D" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.134055>
CMD: svn "diff" "-r" "1" "-N"
"svn-test-work/working_copies/diff_tests-6/A/D" "--config-dir"
"/Users/glasser/Projects/Subversion/1.4.x/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.139914>
FAIL: diff_tests.py 6: non-recursive behaviour

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org