[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25447 - trunk/subversion/tests/cmdline/svntest

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-06-27 00:10:09 CEST

Daniel Rall wrote:
>
>> --- trunk/subversion/tests/cmdline/svntest/main.py (original)
>> +++ trunk/subversion/tests/cmdline/svntest/main.py Mon Jun 18 11:55:24 2007
>> @@ -806,8 +806,11 @@
>>
>> self.result, self.stdout_lines, self.stderr_lines =\
>> spawn_process(command, 1, None, *args)
>> - sys.stdout.write('.')
>> + # don't trust the exitcode, will not be correct on Windows
>> + if filter(lambda x: x[:6] == 'FAIL: ', self.stdout_lines):
>> + self.result = 1
>> self.tests.append(self)
>> + sys.stdout.write('.')
>>
>
> How about x.startswith('FAIL: ') instead?
>
Just checking, you realize that this doesn't help getting rid of the
lambda, right? I personally find the above easier to read, but either is
fine by me.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 27 00:05:49 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.