[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25542 - trunk/subversion/mod_dav_svn/reports

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-06-26 16:33:46 CEST

On Tue, Jun 26, 2007 at 07:53:02PM +0530, Kamesh Jayachandran wrote:
> > I thought we'd effectively deprecated SVN_REVNUM_T_FMT? On checking, I
> > see there's a message about not using it within gettext() strings (which
> > doesn't apply here), so I'm not sure.
> >
> > Anyone: are we supposed to use SVN_REVNUM_T_FMT in new code?
> >
> Sorry I was not aware of it. When was it deprecated? If you can point me to
> that discussion, that would be great.

From searching around, it appears that I'm remembering e.g. r9691,
r12860, and http://svn.haxx.se/dev/archive-2004-05/0480.shtml.

> Rest of operational logging code uses 'SVN_REVNUM_T_FMT'.

Yes, and it might be okay. I'm not sure if the prohibition against
SVN_REVNUM_T_FMT is intended globally, or just in gettext() strings.

I'd suggest that since we need to do the latter, we might as well do
the former as well, but I'm not sure if that the general consensus. If
it is, I'd be happy to clarify the documentation and sweep through the
existing uses, so don't worry about this one.


  • application/pgp-signature attachment: stored
Received on Tue Jun 26 16:33:28 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.