Malcolm Rowe wrote:
> On Tue, Jun 26, 2007 at 04:07:13PM +0530, Kamesh Jayachandran wrote:
>
>> The recent enhancements to Subversion operational logging to trunk won't be
>> backward compatible.
>>
>
> I don't really know how much of a problem that is - did we ever promise
> that it would be?
>
>
I could not see any such promise.
>> But I have one more improvement in mind that won't allow adding fields at
>> the end.
>> The improvement is consistent style of fields like revision should be the
>> last field, so that parsing would be easier.
>> i.e In 1.5.0-dev for 'checkout' we added revision number for commit and we
>> added the 'common-parent-of changed-paths' to commit, adding this new info
>> at the end would break the above improvement of consistent logging.
>>
>
> I couldn't parse that, sorry.
>
Thanks Mike for clarifying what I meant.
>
>> 1.4.4 1.5.0-dev
>> -----------------------------------------------------------------
>> commit r8 commit '/trunk'
>> r8
>> list-dir /trunk list-dir
>> '/trunk' r8
>> blame /trunk/test.c blame
>> '/trunk/test.c' r8:17
>> diff-or-merge '/left_path' '/right_path' diff-or-merge '/trunk' r5:9
>> Or diff-or-merge '/left_path@84' '/right_path@94'
>> switch '/source_path' '/destination_path' switch '/left_path@84'
>> '/right_path@94'
>>
>> In summary I would like to go-ahead with the format of
>> 'command path(s) rREV".
>>
>
> While that's not a bad idea, I don't think we can shoehorn all possible
> commands into that format. See, for example, the diff and switch
> commands above. But I'm all for consistency when there's no reason not
> to switch.
>
>
Yes it may not be possible always, but wherever possible we should.
>> This needs a change to 'revprop-change' log and 'replay'
>> revprop-change r8, 'svn:log' -> revprop-change 'svn:log' r8
>>
>
> I'm -0 on that change: svn:log isn't a path, and for revprop-changes the
> revision is the immediate target of the change.
>
Yes. In concept I agree with you.
But having consistent representation would ease the parsing of this data
with single regex something like(not a complete one)
regex = '(?P<command>.*?) \'(?P<path_or_rev_prop>.*?)\'
(r(?P<revno>\d*))*'.
>
>> replay 8 '/trunk' -> replay '/trunk' r8
>>
>
> On the other hand, that looks like a good change to make.
>
Fixed in r25542.
Thanks
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 26 14:16:19 2007