[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: augmented diff design patch format

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2007-06-26 07:17:48 CEST

"C. Michael Pilato" <cmpilato@collab.net> writes:

> I suspect that to the degree that patch review via email is common, patches
> which include binary file, tree changes, and property mods are *un*common.

Patches that add, rename, and delete are common.

> So I see no reason to require folks to send both styles of patch unless both
> styles are needed. The change to our patch submission guidelines is a one
> sentence mod:
>
> If your patch, when applied to clean working copy, does not produce
> results which, if committedly immediately thereafter, result in the
> exact change you intended (including added and removed files and
> property modifications), then please also include a --deltas version
> of your patch file.

If the output of 'svn diff --deltas' is not human-readable, that
is a problem. If it is human-readable, why not just generate it
unconditionally?

--
Eric Gillespie <*> epg@pretzelnet.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 26 07:17:31 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.