In order to avoid regression, why not add a small regression test? :)
Lieven
glasser@tigris.org wrote:
> Author: glasser
> Date: Mon Jun 25 12:00:37 2007
> New Revision: 25536
>
> Log:
> Fix a segfault introduced in r22671 for when ra_neon tries to connect
> to an URL that is not in a repository.
>
> * subversion/libsvn_ra_neon/props.c
> (svn_ra_neon__search_for_starting_props): Make sure not to clear an error
> until after it might be wrapped.
>
> Modified:
> trunk/subversion/libsvn_ra_neon/props.c
>
> Modified: trunk/subversion/libsvn_ra_neon/props.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra_neon/props.c?pathrev=25536&r1=25535&r2=25536
> ==============================================================================
> --- trunk/subversion/libsvn_ra_neon/props.c (original)
> +++ trunk/subversion/libsvn_ra_neon/props.c Mon Jun 25 12:00:37 2007
> @@ -682,8 +682,6 @@
>
> if (err->apr_err != SVN_ERR_RA_DAV_PATH_NOT_FOUND)
> return err; /* found a _real_ error */
> - else
> - svn_error_clear(err);
>
> /* else... lop off the basename and try again. */
> svn_stringbuf_set(lopped_path,
> @@ -697,6 +695,8 @@
> if (path_s->len == len)
> return svn_error_quick_wrap
> (err, _("The path was not part of a repository"));
> +
> + svn_error_clear(err);
> }
>
> /* error out if entire URL was bogus (not a single part of it exists
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 25 21:02:52 2007