[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Re: svn commit: r25510 - trunk/subversion/tests/cmdline

From: Paul Burba <pburba_at_collab.net>
Date: 2007-06-25 15:43:55 CEST

> -----Original Message-----
> From: Paul Burba [mailto:pburba@collab.net]
> Sent: Monday, June 25, 2007 9:26 AM
> To: Lieven Govaerts; Mark Phippard
> Cc: dev@subversion.tigris.org; hwright@tigris.org; Daniel Rall
> Subject: Re: svn commit: r25510 - trunk/subversion/tests/cmdline


> Log.c:do_merged_log() - Local variable "svn_boolean_t
> changed" is not initialized before being passed by reference
> to check_history(). Great, except that check_history doesn't
> always modify that arg:
> /* Set INFO->HIST to the next history for the path *if* there
> is history
> * available and INFO->HISTORY_REV is equal to or greater
> than CURRENT.
> *
> * *CHANGED is set to TRUE if the path has history in the
> CURRENT revision,
> >>>> * otherwise it is not touched. <<<<
> *
> * If we do need to get the next history revision for the path, call
> * get_history to do it -- see it for details.
> */


Just thinking out loud, but is it really wise to have functions like
check_history() that take a predicate argument but only sometimes
modifies it? Doesn't seem we do that anywhere else that I can recall
(though I haven't made an exhaustive search).


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 25 15:45:05 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.