On 6/24/07, David Glasser <glasser@mit.edu> wrote:
> The svnserve protocol has two versions, v1 and v2. It also has a
> variety of extra "capabilities", including "edit-pipeline".
>
> v2 and edit-pipeline were introduced before Subversion 1.0.0 was
> released. Our general compatibility guidelines do not require us to
> continue to be compatible with pre-1.0 clients or servers.
>
> Is there any reason not to drop support for v1 and non-edit-pipeline
> clients and servers? That is, we would raise the minimum version
> required by the server to 2, and make both client and server error out
> if the other side is not advertising the edit-pipeline capability.
>
> This would allow us to remove a large amount of duplicated dead code
> (including some code that has always been dead, like the non-pipeline
> implementation of ra_replay).
>
> There are even checklists in various places in the code giving hints
> as to what needs to be changed (see
> libsvn_ra_svn/client.c(open_session), say).
Oh, as a note: one could claim that libsvn_ra_svn/protocol is part of
our declared API, and that therefore refusing to accept
non-edit-pipeline connections breaks the protocol.
This would only be relevant for working with programs that choose to
reimplement the protocol, though, and we've never been 100% clear on
whether or not we need to support that. And even so, the most obvious
example of that (SVNKit) already refuses to deal with any server that
doesn't support edit-pipeline.
--dave
--
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 25 01:45:56 2007