[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Handle failed authentication in ra_serf

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-06-24 01:18:39 CEST

Justin Erenkrantz wrote:
> On 6/23/07, Lieven Govaerts <lgo@mobsol.be> wrote:
>> Attached is a small patch that handles failed authentication in ra_serf.
>> With current trunk when you provide wrong credentials for four times svn
>> will get in an endless loop.
>> I couldn't find an error code for 'Authentication failed', it seems to
>> me that other ra layers are incorrectly using Authori*z*ation failed as
>> error message.
>> Unless anyone objects, I'll commit this tomorrow.
> Looks good - one minor suggestion: tweak handle_auth to return
> svn_error_t and return Authentication failed error inside handle_auth
> (and still do the pending_error set in handle_response). For the
> abort() cases we talked about on IRC, we can return more informative
> error descriptions as well... -- justin
Yep, good point. r25519 already removes some of the abort() calls.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 24 01:14:31 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.