Re: svndumpfilter 1.4.4 (VC8 build) crash
On Thu, 21 Jun 2007, Daniel Rall wrote:
> On Thu, 21 Jun 2007, Jens Peters wrote:
> > Thank you for asking. There aren't any special chars in the props and I can
> > reproduce this crash with other dumpfiles as well. I do however took a look
> > at the trunk development of svndumpfilter and got curios about rev 23494.
> > [svndumpfilter: don't use '%n' in printf strings.
> > In VS2005, Microsoft has deprecated the use of %n as 'inherently
> > insecure' and turning it back on requires a special function call.
> > Suggested by: djh
> > Jonathan Gilbert <email@example.com>
> > * subversion/svndumpfilter/main.c
> > (write_prop_to_stringbuf, output_revision, output_node): Use the return
> > value of sprintf() to determine how many characters were written, rather
> > than using '%n' at the end of the string.]
> > After applying this revision to 1.4.4 everything works as expected with
> > svndumpfilter build against libintl 0.14.6 VC8 build. So I would like to
> > ask if rev23494 can be backported to 1.4.x.
> So nominated, Jens.
And backported to the 1.4.x branch in r25499.
Received on Fri Jun 22 20:00:55 2007
- application/pgp-signature attachment: stored
This is an archived mail posted to the Subversion Dev