[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Adding empty files: change to svn_fs_make_file and documentation for the delta editor?

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-06-21 00:46:11 CEST

"Ben Collins-Sussman" <sussman@red-bean.com> writes:
> But I also agree with David, that an editor drive of "add_file();
> close_file()" should create an empty file. While open_file() means
> "I'm about to do something to this file", I think the add_file() call
> really means "create a file now". Various editors might have some
> flexibility in their implementations, though. One editor might create
> a 0-byte file immediately in add_file(), then append data to it if
> apply_textdelta() is called. A different editor might do nothing
> during add_file(), create *and* append data in apply_textdelta()...
> or, if apply_textdelta() is never called, then close_file() would do
> the work of creating the 0-byte file.
> Either way, as long as "add_file(); close_file()" results in a 0-byte
> file, things are fine.

I agree with Ben's summary, and Mike's agreement with Ben's summary,
and anyone else's agreement with my agreement of any of the above.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 21 00:46:06 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.